Remove orphan hack for Commits.QueryBy() #366
Merged
Merged
Conversation
Member
|
Neat. Thanks a thousand times! 💖 |
Member
|
@dahlbyk Thanks for taking care of this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #30, #355
This seems like a more reliable way to support any empty commit list since
HEADon orphan branches.d31afcd includes a breaking change to handling for
Since = "refs/remotes/master"that I think is the right thing to do: the branch doesn't exist, so we shouldn't go out of our way in this case to make it behave as if it does.That said, if I'm on the wrong side of the "orphan branch as semi-real reference but only for
CommitLog" issue, e6dbc3a makes the behavior depend on the currentHEADref rather than hard-coded tomaster./cc @tclem @jamill @nulltoken